Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use global as default name for global object. #60

Closed
tripodsan opened this issue May 10, 2019 · 2 comments · Fixed by #61
Closed

use global as default name for global object. #60

tripodsan opened this issue May 10, 2019 · 2 comments · Fixed by #61
Labels
released

Comments

@tripodsan
Copy link
Contributor

the current compiler allows to define 1 variable name for the runtime globals. but it is not possible to have more external globals. the globals space used by the scripts should not be mixed with the external globals.

the runtime.globals should be read-only. and the runtTimeGlobal name should default to global (or window :-)
@tripodsan
Copy link
Contributor Author

tripodsan commented May 13, 2019 •
edited
Loading

ah. I was mistaken. the runtimeGlobalName is the name of global object and it should default to global.

@tripodsan tripodsan changed the title Add possibility to specify several external global objects use global as default name for global object. May 13, 2019
tripodsan added a commit that referenced this issue May 13, 2019
@tripodsan
fix(compiler): rename global object to global
825a51e 
fixes #60
@tripodsan tripodsan mentioned this issue May 13, 2019
Merged
tripodsan added a commit that referenced this issue May 13, 2019
@tripodsan
fix(compiler): rename global object to global (#61)
8a398f1 
fixes #60
adobe-bot pushed a commit that referenced this issue May 13, 2019
@semantic-release-bot
chore(release): 2.2.2 [skip ci]
c6b8ae6 
## [2.2.2](v2.2.1...v2.2.2) (2019-05-13)

### Bug Fixes

* **compiler:** rename global object to `global` ([#61](#61)) ([8a398f1](8a398f1)), closes [#60](#60)
@adobe-bot
Copy link

🎉 This issue has been resolved in version 2.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(compiler): rename global object to global adobe/htlengine
2 participants
@tripodsan @adobe-bot