Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data-sly-call should not unwrap the element #58

Closed
tripodsan opened this issue May 9, 2019 · 2 comments · Fixed by #59
Closed

data-sly-call should not unwrap the element #58

tripodsan opened this issue May 9, 2019 · 2 comments · Fixed by #59
Assignees
@tripodsan
Labels
released

Comments

@tripodsan
Copy link
Contributor

tripodsan commented May 9, 2019 •
edited
Loading

according to the call spec, the element should remain and the contents be replaced by the template.

so:

<template data-sly-template.one>blah</template>
<div data-sly-call="${one}"></div>

should output

<div>blah</div>

but the htlengine removes the outer element.
@tripodsan
Copy link
Contributor Author

the java version only ignores the child elements:
https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/blob/master/src/main/java/org/apache/sling/scripting/sightly/impl/plugin/CallPlugin.java

@tripodsan tripodsan self-assigned this May 9, 2019
tripodsan added a commit that referenced this issue May 9, 2019
@tripodsan
fix(call): do not unwrap call element
0c3bd13 
fixes #58
@tripodsan tripodsan mentioned this issue May 9, 2019
Merged
tripodsan added a commit that referenced this issue May 9, 2019
@tripodsan
fix(engine): do not unwrap call element (#59)
8963ead 
fixes #58
adobe-bot pushed a commit that referenced this issue May 9, 2019
@semantic-release-bot
chore(release): 2.2.1 [skip ci]
c171f00 
## [2.2.1](v2.2.0...v2.2.1) (2019-05-09)

### Bug Fixes

* **engine:** do not unwrap call element ([#59](#59)) ([8963ead](8963ead)), closes [#58](#58)
@adobe-bot
Copy link

🎉 This issue has been resolved in version 2.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tripodsan tripodsan

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(call): do not unwrap call element adobe/htlengine
2 participants
@tripodsan @adobe-bot