Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

join fails on strings #196

Closed
jantimon opened this issue Jun 26, 2020 · 0 comments
Closed

join fails on strings #196

jantimon opened this issue Jun 26, 2020 · 0 comments

Comments

@jantimon
Copy link
Contributor

The join function is meant to join arrays.
For example:

${someValue @ join = '-'}

However there is one inconsistency with java htl engine.

In java someValue can be a string or undefined.
In javascript only arrays are allowed.

Can you please align both engines?
jantimon added a commit to jantimon/htlengine that referenced this issue Jun 26, 2020
@jantimon
fix: allow to join strings (adobe#196)
c0d11fa
@jantimon jantimon mentioned this issue Jun 26, 2020
Merged
10 tasks
tripodsan pushed a commit that referenced this issue Jun 27, 2020
@jantimon
fix: allow to join strings (#196) (#197)
b6b067f
adobe-bot pushed a commit that referenced this issue Jun 27, 2020
@semantic-release-bot
chore(release): 4.5.1 [skip ci]
1ddfcb6 
## [4.5.1](v4.5.0...v4.5.1) (2020-06-27)

### Bug Fixes

* allow to join strings ([#196](#196)) ([#197](#197)) ([b6b067f](b6b067f))
panec pushed a commit to panec/htlengine that referenced this issue Jul 24, 2020
@maciej-panecki-wttech
Merge branch 'master' into 221-Error-when-href-is-empty
475870d 
* master: (32 commits)
  chore(release): 4.6.2 [skip ci]
  fix(runtime): runtime cannot be executed twice (adobe#218)
  chore(deps): update dependency eslint to v7.5.0
  chore(deps): update external fixes
  chore(deps): bump lodash from 4.17.14 to 4.17.19 in /examples/jsdom (adobe#213)
  chore(release): 4.6.1 [skip ci]
  fix(deps): update dependency lodash to v4.17.19 [security] (adobe#212)
  chore(deps): update dependency jsdom to v16.3.0
  chore(deps): bump npm from 6.14.5 to 6.14.6 (adobe#207)
  chore(release): 4.6.0 [skip ci]
  feat(runtime): Add support for Internet Explorer 11
  chore(deps): update dependency eslint to v7.4.0
  chore(release): 4.5.2 [skip ci]
  fix(xss): test xss against original form (adobe#200)
  chore(deps): update external (adobe#199)
  chore(release): 4.5.1 [skip ci]
  fix: allow to join strings (adobe#196) (adobe#197)
  chore(deps): update external (adobe#195)
  chore(deps): update external (adobe#193)
  chore: better language (adobe#191)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tripodsan @jantimon