Skip to content
This repository has been archived by the owner on Sep 23, 2021. It is now read-only.

problems with git-server #92

Closed
tripodsan opened this issue Nov 12, 2018 · 3 comments
Closed

problems with git-server #92

tripodsan opened this issue Nov 12, 2018 · 3 comments

Comments

@tripodsan
Copy link
Contributor

the git-server dependency is set to "^0.9.7" which includes [email protected].
but since a newer git-server 0.9.10 is released, which includes [email protected] downstream dependencies will use the later git-server.

in circleci, the newer nodegit leads to problems, but it is not possible to revert back to the old version of helix-simulator.

$ npm ls nodegit
@adobe/[email protected] /Users/tripod/codez/helix/project-helix/modules/helix-cli
└─┬ @adobe/[email protected]
  └─┬ @adobe/[email protected]
    └── [email protected]

--> after addinh nodegit as hard dependency to helix-cli:

$ npm ls nodegit
@adobe/[email protected] /Users/tripod/codez/helix/project-helix/modules/helix-cli
└─┬ @adobe/[email protected]
  └── [email protected]

Suggest

  • either use fixed reference for the git-server dependency here,
  • or, git-server should use semver and increase at least the minor version when using a potential breaking change of nodegit.
@tripodsan
Copy link
Contributor Author

/cc @stefan-guggisberg

tripodsan added a commit to adobe/helix-cli that referenced this issue Nov 12, 2018
* Reverts: "update [email protected] to [email protected] (#314)"
* explicitly downgrade git-server (see adobe/helix-simulator#92)
@stefan-guggisberg
Copy link
Contributor

i agree, +1 for using fixed version for the git-server dependency in helix-simulator.

@stefan-guggisberg
Copy link
Contributor

resolved by using fixed version for git-server dependency (284ccda).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants