Skip to content
This repository has been archived by the owner on Sep 23, 2021. It is now read-only.

Proxy strains does not work on URL path #213

Closed
tripodsan opened this issue May 10, 2019 · 3 comments
Closed

Proxy strains does not work on URL path #213

tripodsan opened this issue May 10, 2019 · 3 comments
Labels
bug Something isn't working released

Comments

@tripodsan
Copy link
Contributor

Still seeing the same issue w/ helix-cli 2.1.6.

Relevant helix config part:

  - name: support-staging
    origin: https://adobedocs.github.io/developer-support/
    url: https://adobedevsite.helix-demo.xyz/support

Run hlx up --host adobedevsite.helix-demo.xyz --local-repo=., then load http://localhost:3000/support

Get a 404 page, and hlx up output says:

[hlx] info: Proxy GET request to https://adobedocs.github.io:443/support

The expectation is that hlx up output would provide the correct path to the github.io URL.

Originally posted by @filmaj in adobe/helix-publish#64 (comment)
@tripodsan tripodsan changed the title Still seeing the same issue w/ helix-cli 2.1.6. Proxy strains does not work on URL path May 10, 2019
@tripodsan tripodsan added the bug Something isn't working label May 10, 2019
@trieloff trieloff mentioned this issue May 10, 2019
Closed
tripodsan pushed a commit that referenced this issue May 13, 2019
@semantic-release-bot
chore(release): 2.12.8 [skip ci]
c79e8b4 
## [2.12.8](v2.12.7...v2.12.8) (2019-05-13)

### Bug Fixes

* **esi:** use latest nodesi ([e7bfb2d](e7bfb2d)), closes [#212](#212)
* **server:** fallback to static resolution if template execution fails with 404 ([16f53cf](16f53cf)), closes [#216](#216)
* **server:** Proxy strains does not work on URL path ([a5f3f8e](a5f3f8e)), closes [#213](#213)
@adobe-bot
Copy link

🎉 This issue has been resolved in version 2.12.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@filmaj
Copy link
Contributor

filmaj commented May 13, 2019

Confirmed seems to work in 2.5.0.

@tripodsan tripodsan mentioned this issue May 14, 2019
Closed
@hirenoble
Copy link
Contributor

Thank you everyone!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@filmaj @tripodsan @hirenoble @adobe-bot