process POST request body and pass it to the action

[rofe]

Like openwhisk, the helix-simulator should process the request body and provide it to the action.

[tripodsan]

Can you elaborate an example of what is missing? Do you want to handle POST requests?

[tripodsan]

Btw: do you mean context.request.body ?

[rofe]

Yes, I'd like to be able to POST data to a local dev server and make use of the fact that the pipeline only fetches markdown if there isn't already a content.body present in the payload, e.g. for live markdown preview. I can already do the same by posting {"content":"body":"foo"}} to a Helix html action in openwhisk, but when I do the same with a local server, payload.content is always empty. I would expect the simulator to behave the same as openwhisk.

[tripodsan]

I don't think we should mix things here. Everything coming from the request should be in context.request and not context.content

[rofe]

I can see your concerns. On the other hand, this is how skipping the fetch step in the pipeline was designed by @trieloff (and used in the authoring POC from the Berkeley hackathon), and this change here would allow developers/content authors to make use also in local development. It could come in handy for "as you type" markdown previewing at some point...

I'm open to refactoring all of it and propose to discuss the implementation details in #180 and adobe/helix-pipeline#236 respectively.

[tripodsan]

ok, I was confused. yes, it should populate all action params, like openwhisk does:

The __ow_body property is present either when handling "raw" HTTP requests, or when the HTTP request entity is not a JSON object or form data. Web actions otherwise receive query and body parameters as first class properties in the action arguments with body parameters taking precedence over query parameters, which in turn take precedence over action and package parameters.

[tripodsan]

🎉 This issue has been resolved in version 2.12.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[rofe]

Fixed in 4292fc7: top level properties in the request body will be passed as action params.