allow merging of configs #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…function required for adobe/helix-cli#821
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
=========================================
Coverage ? 98.88%
=========================================
Files ? 18
Lines ? 1341
Branches ? 282
=========================================
Hits ? 1326
Misses ? 15
Partials ? 0
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
tripodsan
reviewed
May 7, 2019
| * object and a user-defined resolver function. | ||
| * @param {HelixConfig} other another Helix Config to merge | ||
| * @param {ResolveFn} resolvefn a resolver function that returns either a strain or undefined | ||
| * @returns {HelixConfig} the merged Helix Config |
There was a problem hiding this comment.
@trieloff I would return a new config and leave the original untouched. or at least clarify that your are returning this.
trieloff
added a commit
that referenced
this pull request
May 8, 2019
…ig, albeit updated) resolves #107 (review)
|
🎉 This issue has been resolved in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
required for adobe/helix-cli#821