Vary on X-Request-Type to prevent Dynamic 404s to be counted against …

…Static refetches, fixes #45 (potentially badly)
adobe · Mar 15, 2019 · 308f424 · 308f424
1 parent 7f68958
commit 308f424
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/layouts/fastly/helix.vcl b/layouts/fastly/helix.vcl
@@ -860,6 +860,12 @@ sub vcl_fetch {
     set beresp.http.Vary = beresp.http.Vary + ",X-Strain";
   }
 
+  # Vary on Request-Type, so that static requests don't interfere with
+  # dynamic requests: https://github.com/adobe/helix-publish/issues/45
+  if (beresp.http.Vary !~ "X-Request-Type") {
+    set beresp.http.Vary = beresp.http.Vary + ",X-Request-Type";
+  }
+
   # TODO: Add Surrogate-Keys, based on req.url/X-Orig-URL
 
   if (beresp.http.Expires || beresp.http.Surrogate-Control ~ "max-age" || beresp.http.Cache-Control ~ "(s-maxage|max-age)") {