refactor(pipe): removed before() and after()

BREAKING CHANGE: removed before() and after() methods in favor of use()

src/pipeline.js

@@ -126,10 +126,15 @@ class Pipeline {
       // if something has been found in the list, insert the
       // new function into the list, with the correct offset
       if (foundstep !== -1) {
-        if (offset === -1) {
+        if (offset < 0) {
+          // replace
           this._steps.splice(foundstep, 1, f);
+        } else if (offset > 0) {
+          // insert after
+          this._steps.splice(foundstep + 1, 0, f);
         } else {
-          this._steps.splice(foundstep + offset, 0, f);
+          // insert before (default)
+          this._steps.splice(foundstep, 0, f);
         }
       } else {
         this._action.logger.warn(`Unknown extension point ${name}`);
@@ -173,26 +178,6 @@ class Pipeline {
     return this;
   }
 
-  /**
-   * Adds a processing function to the `pre` list of this pipeline.
-   * @param {pipelineFunction} f function to add to the `pre` list
-   * @returns {Pipeline} this
-   * @deprecated Call use() instead
-   */
-  before(f) {
-    return this.use(f);
-  }
-
-  /**
-   * Adds a processing function to the `post` list of this pipeline.
-   * @param {pipelineFunction} f function to add to the `post` list
-   * @returns {Pipeline} this
-   * @deprecated Call use() instead
-   */
-  after(f) {
-    return this.use(f);
-  }
-
   /**
    * Adds a tap (observing) function to the pipeline. taps are executed for every
    * single pipeline step and best used for validation, and logging. taps don't have

test/testPipeline.js

@@ -33,10 +33,10 @@ describe('Testing Pipeline', () => {
     const order = [];
     await new Pipeline({ logger })
       .use(() => { order.push('pre0'); })
-      .before(() => { order.push('pre1'); }) // test deprecated before()
+      .use(() => { order.push('pre1'); })
       .once(() => { order.push('once'); })
       .use(() => { order.push('post0'); })
-      .after(() => { order.push('post1'); }) // test deprecated after()
+      .use(() => { order.push('post1'); })
       .run();
     assert.deepEqual(order, ['pre0', 'pre1', 'once', 'post0', 'post1']);
   });