fix(embeds): remove dataEmbed nodes from mdast after detection

package.json

@@ -61,7 +61,7 @@
     "fs-extra": "^8.1.0",
     "github-slugger": "^1.2.1",
     "js-yaml": "^3.13.1",
-    "jsdom": "16.2.0",
+    "jsdom": "^16.2.1",
     "lodash": "^4.17.15",
     "mdast-util-to-hast": "^8.0.0",
     "mdast-util-to-string": "^1.0.6",
@@ -76,6 +76,7 @@
     "strip-markdown": "^3.1.0",
     "unified": "^8.3.2",
     "unist-util-map": "^2.0.0",
+    "unist-util-remove": "^2.0.0",
     "unist-util-select": "^3.0.0",
     "unist-util-visit": "^2.0.0",
     "uri-js": "^4.2.2",

src/html/data-sections.js

@@ -10,6 +10,7 @@
  * governing permissions and limitations under the License.
  */
 const { selectAll } = require('unist-util-select');
+const remove = require('unist-util-remove');
 
 /**
  * Copied from 'unist-util-map' and promisified.
@@ -39,11 +40,9 @@ async function data({ content: { mdast } }, { downloader }) {
       if (node.type === 'dataEmbed') {
         const task = downloader.getTaskById(`dataEmbed:${node.url}`);
         const downloadeddata = await task;
-        console.log('task data', downloadeddata);
+        // TODO: better error handling
         const json = await downloadeddata.json();
-        console.log('data', json);
         section.meta.embedData = json;
-        node.type = 'delete';
       }
       return node;
     });
@@ -56,6 +55,7 @@ async function data({ content: { mdast } }, { downloader }) {
   // extract data from the root node (in case there are no sections)
   await extractData(mdast);
   console.log('found data sections', dataSections.length);
+  remove(mdast, 'dataEmbed');
 }
 
 module.exports = data;