Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package): add more modules to packager #974

Merged
merged 1 commit into from
Jun 10, 2019

Conversation

tripodsan
Copy link
Contributor

fixes #966

Note: This is not a very satisfying fix. the problem here is really, to determine the minimal set of node modules to run this in production, w/o relying on the dev-dependencies.

@codecov
Copy link

codecov bot commented Jun 10, 2019

Codecov Report

Merging #974 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #974   +/-   ##
=======================================
  Coverage   91.78%   91.78%           
=======================================
  Files          47       47           
  Lines        1923     1923           
=======================================
  Hits         1765     1765           
  Misses        158      158
Impacted Files Coverage Δ
src/parcel/packager-config.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b38eb05...b074aaf. Read the comment docs.

@tripodsan tripodsan merged commit 33d64bc into master Jun 10, 2019
@tripodsan tripodsan deleted the add-more-modules-to-packager branch June 10, 2019 23:36
trieloff pushed a commit that referenced this pull request Jun 10, 2019
## [4.2.4](v4.2.3...v4.2.4) (2019-06-10)

### Bug Fixes

* **package:** add more modules to packager ([#974](#974)) ([33d64bc](33d64bc)), closes [#966](#966)
@adobe-bot
Copy link
Collaborator

🎉 This PR is included in version 4.2.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing dependencies when using the globally install helix-cli
2 participants