Remote perf #676
Merged
Remote perf #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- all tests succeeded - all tests failed - tests never returned - some tests succeeded, some never returned
Codecov Report
@@ Coverage Diff @@
## master #676 +/- ##
==========================================
+ Coverage 85.77% 87.49% +1.71%
==========================================
Files 41 41
Lines 2144 2151 +7
Branches 313 317 +4
==========================================
+ Hits 1839 1882 +43
+ Misses 305 269 -36
Continue to review full report at Codecov.
|
|
@trieloff do you still need this branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This took longer than expected, but the PR replaces most of the
hlx perfimplementation. Instead of callingcalibredirectly, which requires each user to have their own set of Calibre credentials, it uses thehelix-perfmicro service (which authenticates against Fastly and uses shared Calibre credentials). This way, performance testing is limited to people (or bots) who can publish and the credential footprint of Helix is a bit reduced.In addition, this PR brings up the coverage for the perf command to 100%, which is much easier now that the entire service is under our control.