Implement github authentication helper #547
Conversation
|
This pull request introduces 1 alert when merging 97c9020 into b338328 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
Codecov Report
@@ Coverage Diff @@
## master #547 +/- ##
==========================================
+ Coverage 85.61% 85.68% +0.06%
==========================================
Files 38 41 +3
Lines 1933 2102 +169
Branches 284 305 +21
==========================================
+ Hits 1655 1801 +146
- Misses 278 301 +23
Continue to review full report at Codecov.
|
tripodsan
changed the title
tripodsan
changed the title
| const packagejson = require('../package.json'); | ||
|
|
||
| function getVersion() { | ||
| return packagejson.version; | ||
| } | ||
|
|
||
| const spinnerFrames = process.platform === 'win32' |
There was a problem hiding this comment.
Is this really a platform dependency or a terminal dependency, i.e. we can assume UTF-8 support when $TERM=xterm?
There was a problem hiding this comment.
don't know :-) I copy pasted it from somewhere. but let me try it out....
There was a problem hiding this comment.
in command prompt, the spinner doesn't work
in hyper terminal, it works:
There was a problem hiding this comment.
apparently this is a known problem. https://github.com/sindresorhus/figures
I'd stick to the distinction for now.
see #380, see #579
NOTE: The name the
testZAuthCmd.jsfile is choosen in such a way that tests are executed after the replay tests intestPublishCmd.js. it seems impossible to re-init replay after nockmessed with the http request classes.