fix(cli): add error message for hlx up command in submodule repo #1796
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1796 +/- ##
==========================================
+ Coverage 94.79% 94.80% +0.01%
==========================================
Files 35 35
Lines 1748 1753 +5
==========================================
+ Hits 1657 1662 +5
Misses 91 91
Continue to review full report at Codecov.
|
src/up.cmd.js
Outdated
| if (!await fse.pathExists(path.join(this.directory, '.git'))) { | ||
| throw Error('hlx up needs local git repository.'); | ||
| try { | ||
| const stat = await fse.lstat(path.join(this.directory, '.git')); |
There was a problem hiding this comment.
| const stat = await fse.lstat(path.join(this.directory, '.git')); | |
| const stat = await fse.lstat(path.resolve(this.directory, '.git')); |
|
@tripodsan what's the process for merges? squash? let approver merge? |
no, it's usually the PR author that does the merge. if squash or merge is a personal choice :-) but all commits need to adhere to the commit message rules (https://github.com/conventional-changelog/conventional-changelog/tree/master/packages/conventional-changelog-angular) so if you have a lot for small ( note, that semantic-release will create a released base on the commit types. so if you have a |
|
🎉 This PR is included in version 13.4.50 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Related Issues
#1794