Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify: remove --minify and --cache from hlx up/build #986

Closed
tripodsan opened this issue Jun 12, 2019 · 1 comment · Fixed by #987
Closed

simplify: remove --minify and --cache from hlx up/build #986

tripodsan opened this issue Jun 12, 2019 · 1 comment · Fixed by #987
Assignees
@tripodsan
Labels
enhancement New feature or request released

Comments

@tripodsan
Copy link
Contributor

tripodsan commented Jun 12, 2019 •
edited
Loading

suggest to remove --cache and --minify arguments from hlx up and hlx build

  • --cache is an implementation detail of how hlx uses parcel and is not relevant to the user
  • --minify never makes sense for local development. when bundled into actions, the code might be minified during the package stage.
@tripodsan tripodsan added the enhancement New feature or request label Jun 12, 2019
@tripodsan tripodsan self-assigned this Jun 12, 2019
tripodsan added a commit that referenced this issue Jun 12, 2019
@tripodsan
feat(cli): remove --minify and --cache
b598041 
fixes #986
@tripodsan tripodsan mentioned this issue Jun 12, 2019
Merged
trieloff pushed a commit that referenced this issue Jun 12, 2019
@semantic-release-bot
chore(release): 4.3.0 [skip ci]
7f089a7 
# [4.3.0](v4.2.10...v4.3.0) (2019-06-12)

### Features

* **cli:** remove --minify and --cache ([b598041](b598041)), closes [#986](#986)
@adobe-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 4.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tripodsan tripodsan

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cli): remove --minify and --cache adobe/helix-cli
2 participants
@tripodsan @adobe-bot