-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hlx up without config should render with helix-pages code #929
Comments
In a discussion with @davidnuescheler we thought that it might be better and more transparent to checkout the helix-pages repo into the |
the current helix pages tries to include a header and footer md. running this on an empty projects shows ugly errors:
|
🎉 This issue has been resolved in version 4.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
when running
hlx up
with nohelix-config.yaml
nor asrc
directory, the project should render using the fallback code from https://github.com/adobe/helix-pages.The code should be provided via an npm package, so that it is stable in respect to semver when installing
helix-cli
, but also allows to update if needed. alternatively,hlx up
could automatically download the code from github.Suggestion
- [ ] create a `@adobe/helix-pages` npm package that contains the `src` and `htdocs` folder. - [ ] add `@adobe/helix-pages` as `dependency` to `helix-cli` - [ ] `hlx up` will check if a fallback code repository is needed, and if so, it will ensure that the packaged code is used for rendering. eg: 1. set the `code` and `static` repository to `${hlx-cli-installpath}/node_modules/@adobe/helix-pages` 2. set the source directory to `${hlx-cli-installpath}/node_modules/@adobe/helix-pages/src`hlx up
will check if a fallback code repository is needed, and if so, it will ensure that thehelix-pages repository is checked out to
.hlx/pages/master
and the code is used for rendering. eg:static
repository to.hlx/pages/master
.hlx/pages/master/src
The text was updated successfully, but these errors were encountered: