Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helix-static bundle includes entire helix-cli #730

Closed
rofe opened this issue Apr 5, 2019 · 2 comments
Closed

helix-static bundle includes entire helix-cli #730

rofe opened this issue Apr 5, 2019 · 2 comments
Assignees
Labels
bug Something isn't working released

Comments

@rofe
Copy link
Contributor

rofe commented Apr 5, 2019

(This is likely very much related to #589, but maybe it can also be looked at in isolation)

Overview

Surprised by the size of the static.zip (12MB), I looked inside and was surprised to find the entire helix-cli module directory in there, taking up about 2/3 of the file size... is there a specific reason for that?

Details

The remaining 1/3 is used by 48 additional dependencies.

Proposed Actions

Maybe the list of bundled modules could be reduced to "just" the 3 modules actually used by the static.js (and their transient dependencies)?

  • request-promise-native
  • crypto
  • mime-types
@rofe rofe added the question Further information is requested label Apr 5, 2019
@tripodsan
Copy link
Contributor

that is actually a very good question :-)

@tripodsan tripodsan self-assigned this Apr 5, 2019
@tripodsan tripodsan added the bug Something isn't working label Apr 5, 2019
@tripodsan tripodsan changed the title Why is the static action bundling helix-cli? helix-static bundle includes entire helix-cli Apr 5, 2019
@tripodsan tripodsan removed the question Further information is requested label Apr 5, 2019
trieloff pushed a commit that referenced this issue Apr 10, 2019
# [0.14.0](v0.13.14...v0.14.0) (2019-04-10)

### Bug Fixes

* **package:** remove extra modules from static.zip ([7958b47](7958b47)), closes [#730](#730)
* package.json & package-lock.json to reduce vulnerabilities ([#740](#740)) ([c9f509c](c9f509c))
* **release:** use semantic release ([4e2d1a1](4e2d1a1)), closes [#706](#706)

### Features

* **env:** better developer support through env variables ([8f82f00](8f82f00)), closes [#14](#14)
@tripodsan
Copy link
Contributor

🎉 This issue has been resolved in version 0.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

No branches or pull requests

2 participants