Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aem up fails if no remote 'origin' is defined #2369

Closed
mokimo opened this issue May 30, 2024 · 2 comments
Closed

aem up fails if no remote 'origin' is defined #2369

mokimo opened this issue May 30, 2024 · 2 comments
Labels
bug Something isn't working released

Comments

@mokimo
Copy link
Member

mokimo commented May 30, 2024 •
edited
Loading

Description
When running aem up without a git remote called 'origin' being defined, the process fails with a JS error Cannot read properties of null (reading 'repo')
This first popped up a first months ago in discord

To Reproduce
Steps to reproduce the behavior:

  1. Go to any edge delivery services repo
  2. Run aem up after deleting the remote called 'origin'
  3. JS error

Expected behavior
Provide guidance on what error occurred and how to fix it

Screenshots
image

Version:
run: $ aem --version v16.3.17
@mokimo mokimo added the bug Something isn't working label May 30, 2024
@mokimo
Copy link
Member Author

mokimo commented May 30, 2024

A better error should fix this
image

@mokimo mokimo mentioned this issue May 30, 2024
Merged
tripodsan pushed a commit that referenced this issue May 30, 2024
@semantic-release-bot
chore(release): 16.3.18 [skip ci]
27c87f1 
## [16.3.18](v16.3.17...v16.3.18) (2024-05-30)

### Bug Fixes

* improve aem up error handling  ([f319855](f319855)), closes [#2369](#2369)
@tripodsan
Copy link
Contributor

🎉 This issue has been resolved in version 16.3.18 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tripodsan @mokimo