Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

always proxy to main branch by default. #2331

Closed
tripodsan opened this issue Mar 18, 2024 · 1 comment · Fixed by #2333
Closed

always proxy to main branch by default. #2331

tripodsan opened this issue Mar 18, 2024 · 1 comment · Fixed by #2333
Assignees
@tripodsan
Labels
bug Something isn't working released

Comments

@tripodsan
Copy link
Contributor

Description
since all/most of the branch related content is served from disk anyways it would be easier to always serve from the main branch by default. this would allow to remove the (confusing) existence check using requests to fstab.yaml.
@tripodsan tripodsan added the bug Something isn't working label Mar 18, 2024
@tripodsan tripodsan self-assigned this Mar 18, 2024
tripodsan added a commit that referenced this issue Mar 19, 2024
@tripodsan
feat: always proxy from main branch by default
f166662 
fixes #2331

fixes #2328

fixes #2219
@tripodsan tripodsan mentioned this issue Mar 19, 2024
Merged
tripodsan added a commit that referenced this issue Mar 19, 2024
@tripodsan
feat: always proxy from main branch by default (#2333)
e0b9be2 
fixes #2331
fixes #2328
tripodsan pushed a commit that referenced this issue Mar 19, 2024
@semantic-release-bot
chore(release): 16.3.0 [skip ci]
0c96a7f 
# [16.3.0](v16.2.14...v16.3.0) (2024-03-19)

### Features

* always proxy from main branch by default ([#2333](#2333)) ([e0b9be2](e0b9be2)), closes [#2331](#2331) [#2328](#2328)
@tripodsan
Copy link
Contributor Author

🎉 This issue has been resolved in version 16.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tripodsan tripodsan mentioned this issue May 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tripodsan tripodsan

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: always proxy from main branch by default adobe/helix-cli
1 participant
@tripodsan