Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simulator fails to serve pages with webm videos #2276

Closed
trieloff opened this issue Nov 17, 2023 · 2 comments · Fixed by #2278
Closed

Simulator fails to serve pages with webm videos #2276

trieloff opened this issue Nov 17, 2023 · 2 comments · Fixed by #2278
Assignees
@tripodsan
Labels
bug Something isn't working released

Comments

@trieloff
Copy link
Contributor 

error: Failed to proxy Franklin request /assets/header-animation-lets-talk.webm: Cannot set headers after they are sent to the client
Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client
    at new NodeError (node:internal/errors:387:5)
    at ServerResponse.setHeader (node:_http_outgoing:644:11)
    at ServerResponse.header (/Users/[redacted]/.nvm/versions/node/v16.19.1/lib/node_modules/@adobe/helix-cli/node_modules/express/lib/response.js:794:10)
    at ServerResponse.send (/Users/[redacted]/.nvm/versions/node/v16.19.1/lib/node_modules/@adobe/helix-cli/node_modules/express/lib/response.js:174:12)
    at HelixServer.handleProxyModeRequest (file:///Users/[redacted]/.nvm/versions/node/v16.19.1/lib/node_modules/@adobe/helix-cli/src/server/HelixServer.js:95:23)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
@trieloff trieloff added the bug Something isn't working label Nov 17, 2023
@tripodsan tripodsan self-assigned this Nov 17, 2023
@craft-tyler
Copy link

Steps to recreate: (Local dev environment)
https://github.com/craft-tyler/ngc-poc/tree/webm-video-issue

We are seeing some console errors on our local dev environments..
When a webm video file loads on the frontend we are presented with an error in the cli console

image

tripodsan added a commit that referenced this issue Nov 17, 2023
@tripodsan
fix: don't respond when headers already sent
2df03e0 
fixes #2276
@tripodsan tripodsan mentioned this issue Nov 17, 2023
Merged
tripodsan added a commit that referenced this issue Nov 17, 2023
@tripodsan
fix: don't respond when headers already sent (#2278)
6be2f00 
fixes #2276
tripodsan pushed a commit that referenced this issue Nov 17, 2023
@semantic-release-bot
chore(release): 16.0.8 [skip ci]
a40e55c 
## [16.0.8](v16.0.7...v16.0.8) (2023-11-17)

### Bug Fixes

* don't respond when headers already sent ([#2278](#2278)) ([6be2f00](6be2f00)), closes [#2276](#2276)
@tripodsan
Copy link
Contributor

🎉 This issue has been resolved in version 16.0.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tripodsan tripodsan

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: don't respond when headers already sent adobe/helix-cli
3 participants
@trieloff @tripodsan @craft-tyler