Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add option to remove / fix content-security-policy header #2178

Closed
tripodsan opened this issue Apr 19, 2023 · 2 comments · Fixed by #2179
Closed

add option to remove / fix content-security-policy header #2178

tripodsan opened this issue Apr 19, 2023 · 2 comments · Fixed by #2179
Assignees
@tripodsan
Labels
bug Something isn't working released

Comments

@tripodsan
Copy link
Contributor

for projects that set a CSP header, it might cause problems with local dev, such as certain files might not load anymore.

ideally, the server should automatically detect the header and extend it in a way to allow localhost as origin.
a quick solution might be to notify the user and offer a flag to remove the CSP header

workaround: use a browser extension to modify the header, eg:
https://docs.modheader.com/using-modheader/about-modheader
@tripodsan tripodsan added the bug Something isn't working label Apr 19, 2023
@davidnuescheler
Copy link
Contributor

i think we should just remove the CSP header on localhost...

tripodsan added a commit that referenced this issue Apr 20, 2023
@tripodsan
feat: remove content-security-policy header for localhost
58b2e1c 
fixes #2178
@tripodsan tripodsan mentioned this issue Apr 20, 2023
Merged
@tripodsan tripodsan self-assigned this Apr 20, 2023
tripodsan added a commit that referenced this issue Apr 20, 2023
@tripodsan
feat: remove content-security-policy header for localhost (#2179)
ce3261c 
fixes #2178
tripodsan pushed a commit that referenced this issue Apr 20, 2023
@semantic-release-bot
chore(release): 14.23.0 [skip ci]
03985d7 
# [14.23.0](v14.22.13...v14.23.0) (2023-04-20)

### Features

* remove content-security-policy header for localhost ([#2179](#2179)) ([ce3261c](ce3261c)), closes [#2178](#2178)
@tripodsan
Copy link
Contributor Author

🎉 This issue has been resolved in version 14.23.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tripodsan tripodsan

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: remove content-security-policy header for localhost adobe/helix-cli
2 participants
@tripodsan @davidnuescheler