Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kill URL to shut down the server? #1939

Closed
trieloff opened this issue Feb 9, 2022 · 3 comments · Fixed by #1952
Closed

Add kill URL to shut down the server? #1939

trieloff opened this issue Feb 9, 2022 · 3 comments · Fixed by #1952
Labels
enhancement New feature or request released

Comments

@trieloff
Copy link
Contributor

trieloff commented Feb 9, 2022

When working on multiple helix projects at the same time, you will often find out that hlx up fails, because port 3000 is already in use. What if, instead of searching for the console tab that has the running process, you could just curl http://localhost/.kill && hlx up, which would shut down the existing process, free the port and allow starting the new server without leaving the console?
@trieloff trieloff added the enhancement New feature or request label Feb 9, 2022
@tripodsan
Copy link
Contributor

or just:

$ hlx up
there is already a hlx server running (~/helix-project1). do you want to stop it and proceed here?
Y/n

or

$ hlx up --force
terminated prior hlx server (~/helix-project1)

@trieloff
Copy link
Contributor Author

Yes, that would be the user-friendly wrapper around that feature.

trieloff added a commit that referenced this issue Mar 1, 2022
@trieloff
feat(server): add /.kill switch to quickly turn the server off
af2d458 
fixes #1939
trieloff added a commit that referenced this issue Mar 1, 2022
@trieloff
feat(cli): add --kill option (default: on) to kill other Helix CLI …
13275e4 
…server instances on the same port

fixes #1939
@trieloff trieloff mentioned this issue Mar 1, 2022
Merged
adobe-bot pushed a commit that referenced this issue Mar 2, 2022
@semantic-release-bot
chore(release): 14.5.0 [skip ci]
3b12c7d 
# [14.5.0](v14.4.28...v14.5.0) (2022-03-02)

### Features

* **cli:** add `--kill` option (default: on) to kill other Helix CLI server instances on the same port ([13275e4](13275e4)), closes [#1939](#1939)
* **server:** add `/.kill` switch to quickly turn the server off ([af2d458](af2d458)), closes [#1939](#1939)
@adobe-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 14.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement kill switch adobe/helix-cli
3 participants
@trieloff @tripodsan @adobe-bot