Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for new branches locally #1884

Closed
davidnuescheler opened this issue Nov 4, 2021 · 1 comment · Fixed by #1887
Closed

support for new branches locally #1884

davidnuescheler opened this issue Nov 4, 2021 · 1 comment · Fixed by #1887
Assignees
@tripodsan
Labels
enhancement New feature or request released

Comments

@davidnuescheler
Copy link
Contributor

if a branch is created locally this currently creates an issue as the request to <newbranch>--<repo>--<owner>.hlx3.page will correctly produce a 404.
i think in that case (if we can easily detect it) we should fall back to main instead, which shouldn't have a negative impact on the dev experience, as only the contentbus is proxied anyway, as the codebus information is completely available locally anyway.
@davidnuescheler davidnuescheler added the enhancement New feature or request label Nov 4, 2021
@tripodsan tripodsan self-assigned this Nov 8, 2021
tripodsan added a commit that referenced this issue Nov 8, 2021
@tripodsan
fix: fallback to main if current branch is not available yet
5c0daee 
fixes #1884
@tripodsan tripodsan mentioned this issue Nov 8, 2021
Merged
adobe-bot pushed a commit that referenced this issue Nov 9, 2021
@semantic-release-bot
chore(release): 14.0.6 [skip ci]
430889b 
## [14.0.6](v14.0.5...v14.0.6) (2021-11-09)

### Bug Fixes

* don't follow redirects ([d5e32c0](d5e32c0)), closes [#1863](#1863)
* fallback to main if current branch is not available yet ([5c0daee](5c0daee)), closes [#1884](#1884)
@adobe-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 14.0.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tripodsan tripodsan

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes adobe/helix-cli
3 participants
@tripodsan @davidnuescheler @adobe-bot