Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenWhisk error while deploying #1410

Closed
trieloff opened this issue May 27, 2020 · 3 comments
Closed

OpenWhisk error while deploying #1410

trieloff opened this issue May 27, 2020 · 3 comments
Labels
bug Something isn't working released

Comments

@trieloff
Copy link
Contributor 

$ npx hlx --version
10.0.0

$ npx hlx publish
Using @adobe/helix-pipeline version 7.4.1 from .hlx/build/node_modules/@adobe/helix-pipeline.
html (src/html.htl)
cgi-bin-hello (cgi-bin/hello.js)
[==================================================] packaging html.js 10.4s
✅  packaging completed
PUT https://adobeioruntime.net/api/v1/namespaces/trieloff/packages/a89e5c4f0d2649baebb00bb00b3b90983a332845?overwrite=true Returned HTTP 400 (Bad Request) --> "The request content was malformed:
parameters malformed could not read directly: [{"key":"EPSAGON_TOKEN","value":"****"},{"key":"CORALOGIX_API_KEY"},{"key":"CORALOGIX_APPLICATION_NAME"},{"key":"RESOLVE_GITREF_SERVICE","value":"helix-services/resolve-git-ref@v1"},{"key":"EPSAGON_APPLICATION_NAME","value":"Primordialsoup"}]"
Exception: npx exited with 1
[tty], line 1: npx hlx deploy

Looks like we need to guard against empty parameters.
@trieloff trieloff added the bug Something isn't working label May 27, 2020
@tripodsan
Copy link
Contributor

what is the error ?

@trieloff
Copy link
Contributor Author

parameters malformed could not read directly

From OpenWhisk. Probably because

{"key":"CORALOGIX_API_KEY"},{"key":"CORALOGIX_APPLICATION_NAME"}

don't have a value field.

trieloff added a commit that referenced this issue May 27, 2020
@trieloff
test(deploy): add test for deploy with missing parameters
d429dd1 
see #1410
@trieloff trieloff mentioned this issue May 27, 2020
Merged
trieloff pushed a commit that referenced this issue May 27, 2020
@semantic-release-bot
chore(release): 10.0.1 [skip ci]
42bfee4 
## [10.0.1](v10.0.0...v10.0.1) (2020-05-27)

### Bug Fixes

* **deploy:** filter all falsy values from package parameters ([1b99896](1b99896)), closes [#1410](#1410)
@adobe-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 10.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@trieloff @tripodsan @adobe-bot