Weird error if fastly-serviceid parameter is empty

[kptdobe]

Description
I lost plenty of time on this stupid issue. If fastly-serviceid is empty, you get the following error message:

Error while running the Publish command
preparing fastly transaction
error: Error while running the Publish command: FastlyError
    at request.then (/Users/acapt/.nvm/versions/node/v10.16.0/lib/node_modules/@adobe/helix-cli/node_modules/@adobe/fastly-native-promises/src/httpclient.js:107:17)
    at process._tickCallback (internal/process/next_tick.js:68:7)

To Reproduce
Steps to reproduce the behavior:

1. Run hlx publish --fastly-serviceid "" (assuming you have other parameters properly set)

Expected behavior
An error message like when no parameter at all is provided:

Missing required argument: fastly-serviceid
Fastly Service ID is required.

Version:
run: $ hlx --version
4.10.0

[trieloff]

@MarquiseRosier that might be something for you.

[tripodsan]

@kptdobe did you still have the old HLX_FASTY_NAMEPSACE in the .env ?

[MarquiseRosier]

I'm the params man lol

[kptdobe]

@tripodsan No. I think I was fine with the param names, I discovered the issue accidentally on CircleCI where my env variable was not transferred from one step to another thus value was empty. I was doing:

hlx publish --fastly-serviceid $TEST_SERVICE

and TEST_SERVICE was empty. In the previous step, I was setting it properly and echo worked. It is just not "exported" automatically.

It just took me a while to realise the pb was the value and not something related to my npm setup or a weird issue in the cli.

[adobe-bot]

🎉 This issue has been resolved in version 5.0.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀