Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package scripts #61

Merged
merged 4 commits into from
Jun 1, 2020
Merged

Conversation

purplecabbage
Copy link
Member

@purplecabbage purplecabbage commented May 30, 2020

Description

Templates might need to add their own npm-scripts to the project's package.json
This provides a helper function to write it for them.

Related Issue

Motivation and Context

ex.

addPkgScript(generator, {'pretest': 'echo ima run some tests now okey\?')

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jun 1, 2020

Codecov Report

Merging #61 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #61   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          330       334    +4     
  Branches        41        42    +1     
=========================================
+ Hits           330       334    +4     
Impacted Files Coverage Δ
lib/utils.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36ec841...458679d. Read the comment docs.

@purplecabbage purplecabbage merged commit 41c9025 into adobe:master Jun 1, 2020
@purplecabbage purplecabbage deleted the AddPackageScripts branch June 1, 2020 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant