Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMS org id as input header instead of default parameter #44

Merged
merged 2 commits into from
May 11, 2020

Conversation

moritzraho
Copy link
Member

@moritzraho moritzraho commented May 8, 2020

Description

  • x-gw-ims-org-id will be used in the upstream validator and is available as input header
  • add a stub requiredHeaders parameter

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented May 8, 2020

Codecov Report

Merging #44 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #44   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          302       302           
  Branches        39        39           
=========================================
  Hits           302       302           
Impacted Files Coverage Δ
generators/add-action/analytics/index.js 100.00% <ø> (ø)
generators/add-action/campaign-standard/index.js 100.00% <ø> (ø)
generators/add-action/customer-profile/index.js 100.00% <ø> (ø)
generators/add-action/generic/index.js 100.00% <ø> (ø)
generators/add-action/target/index.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbaae0f...2f1b6f7. Read the comment docs.

@chiarabdy chiarabdy mentioned this pull request May 11, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants