Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CI/CD templates to use OAuth STS based token generation. #243

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

sandeep-paliwal
Copy link
Contributor

Update generated CI/CD file to use OAuth STS token generation and move away from deprecated JWT based token generation.
This change depends on recent GH action release 3.0.0 -

Description

Related Issue

Motivation and Context

How Has This Been Tested?

unit tests and manual deploy

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9a3c3af) 100.00% compared to head (af135fe) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #243   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          312       312           
  Branches        44        44           
=========================================
  Hits           312       312           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@pru55e11 pru55e11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@sandeep-paliwal sandeep-paliwal merged commit 7099163 into master Jan 18, 2024
7 checks passed
@purplecabbage purplecabbage deleted the ci_oauth_sts_support branch February 22, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants