Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate web or actions keys in app.config.yaml only when necessary #196

Merged

Conversation

MichaelGoberling
Copy link
Contributor

This pull request proposes only generating the web or actions keys in app.config.yaml when the user initializes an application with the features associated with those keys.

Description

This pull request adds a conditional check during project generation to only add the web or actions keys in app.config.yaml if the user's response to the feature prompt during the aio app init command indicates they are needed.

Related Issue

Closes adobe/aio-cli-plugin-app#555

Motivation and Context

Remove bloat from configuration.

How Has This Been Tested?

npm run test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #196 (5aee0dd) into master (9b43a3b) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #196   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          393       392    -1     
  Branches        44        46    +2     
=========================================
- Hits           393       392    -1     
Impacted Files Coverage Δ
generators/application/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b43a3b...5aee0dd. Read the comment docs.

Copy link
Member

@purplecabbage purplecabbage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved my comment inline ....
LGTM, with a minor suggestion

Copy link
Member

@moritzraho moritzraho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shazron shazron merged commit dba9f6a into adobe:master Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

web-src is always set in the app.config.yaml
4 participants