Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: template extension integration #188

Merged
merged 15 commits into from
Jun 7, 2022
Merged

Conversation

florind-ens
Copy link
Contributor

@florind-ens florind-ens commented Mar 16, 2022

Description

Extensions extracted into separate repos:

Pre-requisites

How Has This Been Tested?

npm test, manual test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…tensions

# Conflicts:
#	generators/add-web-assets/exc-react/templates/src/components/ActionsForm.js
@florind-ens florind-ens requested a review from shazron March 16, 2022 22:11
@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #188 (4e38b31) into master (8c7b113) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            master      #188    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           26        17     -9     
  Lines          648       392   -256     
  Branches        72        44    -28     
==========================================
- Hits           648       392   -256     
Impacted Files Coverage Δ
generators/add-action/analytics/index.js 100.00% <100.00%> (ø)
generators/add-action/audience-manager-cd/index.js 100.00% <100.00%> (ø)
generators/add-action/campaign-standard/index.js 100.00% <100.00%> (ø)
generators/add-action/customer-profile/index.js 100.00% <100.00%> (ø)
generators/add-action/index.js 100.00% <100.00%> (ø)
generators/add-action/target/index.js 100.00% <100.00%> (ø)
generators/add-ci/index.js 100.00% <100.00%> (ø)
generators/add-events/publish-events/index.js 100.00% <100.00%> (ø)
generators/add-web-assets/index.js 100.00% <100.00%> (ø)
generators/application/index.js 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c7b113...4e38b31. Read the comment docs.

package.json Outdated Show resolved Hide resolved
@shazron shazron changed the title Template extension integration feat: template extension integration Mar 18, 2022
@shazron shazron marked this pull request as draft May 20, 2022 15:46
@shazron shazron self-requested a review May 20, 2022 15:46
@shazron shazron requested review from shazron and removed request for shazron June 1, 2022 14:30
@shazron
Copy link
Member

shazron commented Jun 2, 2022

Changes required in exc-shell, app plugin, see Pre-requisites section at the top.

@shazron shazron marked this pull request as ready for review June 7, 2022 17:36
@shazron shazron merged commit c19532b into master Jun 7, 2022
@shazron shazron deleted the task/third-party-extensions branch June 7, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants