Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small error with example command for e2e tests #183

Merged
merged 1 commit into from
Feb 11, 2022
Merged

Fix small error with example command for e2e tests #183

merged 1 commit into from
Feb 11, 2022

Conversation

cpilsworth
Copy link
Contributor

@cpilsworth cpilsworth commented Feb 10, 2022

Description

aio app test -e tries to run tests on an extension only, so the example gives the error:

Error: Flag --extension expects a value

aio app test --e2e will run the end-to-end tests as expected

Related Issue

Closes #182

Motivation and Context

Fixes a minor issue with the generated README file that might slow down or frustrate new users of the platform.

How Has This Been Tested?

Tested updated command locally with the updated command, with reference to the command help.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

`aio app test -e` tries to run tests on an extension only, so the example gives the error `Error: Flag --extension expects a value`.
`aio app test --e2e` will run the end-to-end tests
@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #183 (bd53167) into master (100abd2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #183   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines          645       645           
  Branches        71        71           
=========================================
  Hits           645       645           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 100abd2...bd53167. Read the comment docs.

@shazron shazron merged commit 239e12f into adobe:master Feb 11, 2022
@shazron
Copy link
Member

shazron commented Feb 11, 2022

thank you @cpilsworth !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated README contains invalid command to run the e2e tests
2 participants