Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ext reg - CI/CD template update for deploy #163

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

sandeep-paliwal
Copy link
Contributor

Add required env vars for build and deploy for extension registry
Move Auth generation before build as build also requires token
Reference latest aio apps action 2.0.1

Description

Related Issue

Motivation and Context

How Has This Been Tested?

manual tests, unit-tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Move Auth generation before build as build also requires token
Reference latest aio apps action 2.0.1
@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #163 (64dff46) into master (ef105c2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #163   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines          642       642           
  Branches        70        70           
=========================================
  Hits           642       642           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef105c2...64dff46. Read the comment docs.

@Himavanth
Copy link
Contributor

Himavanth commented Aug 16, 2021

LGTM. @sandeep-paliwal You might want to add the auth command in the readme here https://github.com/adobe/aio-apps-action . Also i'm not sure why build requires the token. I just did aio logout and aio app build and it works fine.

@sandeep-paliwal sandeep-paliwal merged commit 53a7f53 into master Aug 16, 2021
@shazron shazron deleted the cicd_deploy_updates branch October 20, 2022 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants