Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore logs folder for @adobe/aio-run-detached #110

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Conversation

shazron
Copy link
Member

@shazron shazron commented Oct 14, 2020

See adobe/aio-cli-plugin-app#301

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #110 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #110   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines          378       412   +34     
  Branches        47        55    +8     
=========================================
+ Hits           378       412   +34     
Impacted Files Coverage Δ
generators/add-action/analytics/index.js 100.00% <ø> (ø)
generators/add-action/asset-compute/index.js 100.00% <ø> (ø)
generators/add-action/audience-manager-cd/index.js 100.00% <ø> (ø)
generators/add-action/campaign-standard/index.js 100.00% <ø> (ø)
generators/add-action/customer-profile/index.js 100.00% <ø> (ø)
generators/add-action/generic/index.js 100.00% <ø> (ø)
generators/add-action/target/index.js 100.00% <ø> (ø)
generators/add-events/publish-events/index.js 100.00% <ø> (ø)
generators/add-web-assets/exc-react/index.js 100.00% <ø> (ø)
lib/constants.js 100.00% <ø> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10f7851...2a70be2. Read the comment docs.

@shazron shazron requested a review from moritzraho October 14, 2020 07:51
@moritzraho moritzraho merged commit 729697d into master Oct 14, 2020
@moritzraho moritzraho deleted the ignore-logs branch October 14, 2020 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants