Skip to content

Commit

Permalink
fix: vs code launch config: add --disable-concurrency flag for wskdeb…
Browse files Browse the repository at this point in the history
…ug (#128)

With multiple clusters Openwhisk can create multiple containers for a concurrent action even with minimal traffic. Invocations in a cluster will create a new container in the same cluster. If invocations (actual invocation to debug vs. wskdebug polling) happen in different clusters, there will be 2 containers and they won't see each other, and wskdebug will fail to catch any invocations. Uses the activation db polling agent.
  • Loading branch information
shazron authored Jan 26, 2021
1 parent 1e58dfc commit e75be68
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
3 changes: 2 additions & 1 deletion generators/add-vscode-config/VsCodeConfiguration.js
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,8 @@ function createPwaNodeLaunchConfiguration (params) {
runtimeArgs: [
`${packageName}/${actionName}`,
`\${workspaceFolder}/${actionFileRelativePath}`,
'-v'
'-v',
'--disable-concurrency'
]
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,8 @@ test('createPwaNodeLaunchConfiguration', () => {
runtimeArgs: [
`${params.packageName}/${params.actionName}`,
`\${workspaceFolder}/${params.actionFileRelativePath}`, // eslint-disable-line no-template-curly-in-string
'-v'
'-v',
'--disable-concurrency'
]
})
})
1 change: 1 addition & 0 deletions test/generators/add-vscode-config/index.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ const createTestLaunchConfiguration = (packageName) => {
`${packageName}/__secured_action-1`,
'${workspaceFolder}/src/actions/action-1', // eslint-disable-line no-template-curly-in-string
'-v',
'--disable-concurrency',
'--kind',
'nodejs:14'
]
Expand Down

0 comments on commit e75be68

Please sign in to comment.