Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request timeout is not handled properly #261

Closed
stefan-guggisberg opened this issue Oct 28, 2020 · 1 comment · Fixed by #277
Closed

Request timeout is not handled properly #261

stefan-guggisberg opened this issue Oct 28, 2020 · 1 comment · Fixed by #277
Labels
bug Something isn't working released

Comments

@stefan-guggisberg
Copy link

Description
fastly-native-promises uses https://github.com/adobe/helix-fetch as http client and sets a default timeout of 15s. If a requests takes longer than 15s helix-fetch rejects with an AbortError. This error is not handled gracefully but treated as a generic error.

Expected behavior
If a request times out it should be retried or reported as a specific (timeout) error which would allow a client to act accordingly.

Additional context
https://github.com/adobe/helix-fetch#specify-a-timeout-for-a-fetch-operation
@stefan-guggisberg stefan-guggisberg added the bug Something isn't working label Oct 28, 2020
@stefan-guggisberg stefan-guggisberg mentioned this issue Oct 28, 2020
Closed
@trieloff trieloff mentioned this issue Jan 6, 2021
Closed
trieloff added a commit that referenced this issue Jan 6, 2021
@trieloff
fix(http): retry in case of timeouts
1b0f770 
fixes #261
@trieloff trieloff mentioned this issue Jan 6, 2021
Merged
github-actions bot pushed a commit that referenced this issue Jan 6, 2021
@semantic-release-bot
chore(release): 1.19.3 [skip ci]
272ff0f 
## [1.19.3](v1.19.2...v1.19.3) (2021-01-06)

### Bug Fixes

* **http:** retry in case of timeouts ([1b0f770](1b0f770)), closes [#261](#261)
@github-actions
Copy link

github-actions bot commented Jan 6, 2021

🎉 This issue has been resolved in version 1.19.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(http): retry in case of timeouts adobe/fastly-native-promises
1 participant
@stefan-guggisberg