Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding FromCSVToList annotation #42

Merged
merged 6 commits into from
Sep 25, 2023
Merged

adding FromCSVToList annotation #42

merged 6 commits into from
Sep 25, 2023

Conversation

tamagoko
Copy link
Contributor

@tamagoko tamagoko commented Sep 22, 2023 •
edited
Loading 

adding this annotation transforms the model and returns
it as a type T which is specified in the Annotated

documenting the usage for FromCSVToList

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@tamagoko tamagoko force-pushed the csv-annototion-support branch 2 times, most recently from 75a18d6 to 442d47f Compare September 22, 2023 17:12
@benboger
adding FromCSVToList annotation
b6099b1 
	adding this annotation transforms the model and returns
	it as a type T which is specified in the Annotated

	documenting the usage for FromCSVToList
@benboger
dropping support for python 3.7 and 3.8
c3daad0
@tamagoko tamagoko force-pushed the csv-annototion-support branch from 08a9c6b to 4c5beb3 Compare September 22, 2023 17:37
@tamagoko tamagoko force-pushed the csv-annototion-support branch from 4c5beb3 to 884b9ab Compare September 22, 2023 17:41
bluesliverx
bluesliverx reviewed Sep 22, 2023
View reviewed changes
dysql/annotations.py Outdated Show resolved Hide resolved
bluesliverx
bluesliverx reviewed Sep 22, 2023
View reviewed changes
dysql/annotations.py Outdated Show resolved Hide resolved
@tamagoko tamagoko force-pushed the csv-annototion-support branch 4 times, most recently from 8f7184c to 0686e97 Compare September 22, 2023 23:05
@tamagoko tamagoko force-pushed the csv-annototion-support branch from 0686e97 to db34db5 Compare September 22, 2023 23:10
bluesliverx
bluesliverx reviewed Sep 23, 2023
View reviewed changes
.pylint-license-header
@@ -1,5 +1,5 @@
"""
Copyright 2021 Adobe
Copyright 20\d\d Adobe
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll call this the y2.1k bug ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:P

@tamagoko tamagoko merged commit fe26747 into adobe:main Sep 25, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluesliverx bluesliverx bluesliverx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tamagoko @bluesliverx @benboger