This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fix unit tests for non-english locales #8995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cale Conflicts: test/spec/FindReplace-test.js
|
Resolved conflicts. |
|
I can confirm that the function works but I haven't run the tests in another language since I have no language packs installed. |
|
I'll try again later on my Mac |
|
@JeffryBooher You don't have to change the OS language, just change Brackets' language via Debug > Switch language. |
|
I did but I wanted to test with the default OS locale being something other than English. I tested this on Mac Japanese -- change looks good. |
JeffryBooher
added a commit
that referenced
this pull request
Oct 10, 2014
Fix unit tests for non-english locales
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finally found a centralized fix for all the issues with Strings in unit tests.
For #8672.