This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Add link to Troubleshooting page to Live Preview error messages #8734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -619,7 +619,7 @@ define(function LiveDevelopment(require, exports, module) { | |||
| Dialogs.showModalDialog( | |||
| Dialogs.DIALOG_ID_ERROR, | |||
| Strings.LIVE_DEVELOPMENT_ERROR_TITLE, | |||
| Strings.LIVE_DEV_LOADING_ERROR_MESSAGE | |||
| _append(Strings.LIVE_DEV_LOADING_ERROR_MESSAGE) | |||
There was a problem hiding this comment.
Small error (the reason the Travis build failed): function should be _appendTroubleshootingMessage.
There was a problem hiding this comment.
@le717 Thanks! Fixed.
| * @param {string} msg Original message | ||
| * @return {string} Original message plus link to troubleshooting page. | ||
| */ | ||
| function _appendTroubleshootingMessage(msg) { |
There was a problem hiding this comment.
nit: this should be named something like: _makeTroubleshootingMessage It's not appending anything it's concatenating strings and computing a result.
|
Ready for another review. |
|
LGTM. Merging |
JeffryBooher
added a commit
that referenced
this pull request
Sep 16, 2014
Add link to Troubleshooting page to Live Preview error messages
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #7634 for Brackets Milestone 1.0
This is to append link to troubleshooting doc to live preview error message. I went ahead and added the link to all live preview error messages.
@njx I did not reword error message as called for in #7634 -- is this ok? If not, suggestions for rewording?