Spanish update for Release 0.42 #8585
Conversation
| "FONT_SIZE" : "Tamaño de letra", | ||
| "FONT_FAMILY" : "Tipo de letra", | ||
| "LINE_HEIGHT" : "Altura de la línea", | ||
| "GENERAL" : "General", |
There was a problem hiding this comment.
The "LINE_HEIGHT" and "GENERAL" strings were removed in #8563 so you should remove those.
There was a problem hiding this comment.
Fixed. Made the diff from the second commit.
|
@busykai Is on vacation. Any other Spanish speakers around today that can review this? cc @TomMalbran |
| "DIRECTORY" : "directorio", | ||
| "DIRECTORY_TITLE" : "directorio", |
There was a problem hiding this comment.
@TomMalbran The reason for adding "FILE_TITLE" and "DIRECTORY_TITLE" when there was already "FILE" and "DIRECTORY" is to provide capitalized strings for titles. Should these be capitalized?
There was a problem hiding this comment.
I know, but in Spanish we don't use titles where all the letters are capitalized. If you see the menus and every modal dialog, only the first letter is a capital. I changed that recently for the updates.
|
Doing a quick scan right now before going on vacation as well 😉 |
|
@jbalsas Hi. thanks :) |
|
OK, looks good to me. @jbalsas Feel free to merge it when you're done reviewing. |
| @@ -246,6 +248,7 @@ define({ | |||
| "STATUSBAR_USER_EXTENSIONS_DISABLED" : "Extensiones deshabilitadas", | |||
| "STATUSBAR_INSERT" : "INS", | |||
| "STATUSBAR_OVERWRITE" : "SOB", | |||
| "STATUSBAR_DEFAULT_LANG" : "(defecto)", | |||
There was a problem hiding this comment.
Maybe predeterminado would be better? To me, por defecto as a whole construct sounds good, but only defecto sounds closer to defect. What do you think?
There was a problem hiding this comment.
I will use my Spanish in here and agree with @jbalsas. :) I would probably use por defecto though
There was a problem hiding this comment.
Yes, I like por defecto better.
|
@TomMalbran Done with the review... just a few suggestions. I'll be back in a couple of hours before going to bed to merge if no one beats me to it 😉 |
|
@jbalsas Thanks for the review. I fixed all the suggestions. |
|
Awesome, merging then! @TomMalbran nice talking to you again... keep up the good work! ;) @redmunds I'm merging even though the CI build is failing since I see it's also failing on current master for the same reason. Should be worth it to look into it, though. |
Spanish update for Release 0.42
|
@jbalsas Thanks for review and head's up about Travis CI failing! |
| @@ -414,6 +419,12 @@ define({ | |||
| "BASEURL_ERROR_INVALID_CHAR" : "Los caracteres especiales como '{0}' deben codificarse en formato %.", | |||
| "BASEURL_ERROR_UNKNOWN_ERROR" : "Error desconocido analizando la URL base", | |||
|
|
|||
| // Strings for themes-settings.html and themes-general.html | |||
| "CURRENT_THEME" : "Tema actual", | |||
| "USE_THEME_SCROLLBARS" : "Usar scrollbars del tema", | |||
There was a problem hiding this comment.
“Scrollbar” has an equivalent in Spanish: “barra de desplazamiento”.
There was a problem hiding this comment.
Right. Totally forgot about it.
:)
cc @busykai