Adds dark class and moves inline-widget color into core UI theme #8502
Conversation
|
Cool, I had added the dark class in this PR https://github.com/MiguelCastillo/brackets/commit/16aeac1bfcda9c77f13f4ab88a362ae446cc0fe2#diff-82c3690745f7c8a1b46c19bba1804f0aR245 |
|
Ha! I was going to review that PR next. I should have done it first. Can we move the |
|
Yeah man, either way. It seems a bit better to just remove my one liner and merge in your change because this PR is more specific. I like my little toggleClass logic though :D |
|
Yeah, |
| * These are overrides to make the UI look better when the editor theme is dark. | ||
| * Eventually, these will likely be replaced by full-featured UI themes. | ||
| */ | ||
| .dark .inline-widget { |
There was a problem hiding this comment.
To be future-proof, we should do it like this:
.dark {
.inline-widget {
color: #333;
}
}There was a problem hiding this comment.
Yeah, I will probably do that this afternoon as I try to bring in some dark styling to the core UI.
|
@dangoor the new location makes sense 👍 |
See this comment from #8484.
cc @MiguelCastillo to review the ThemeManager change and @larz0 to make sure that the new location for the
.inline-widgetstyle makes sense.