Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Adds 'Brackets Homepage' entry to help menu #7746

Merged
merged 2 commits into from
May 15, 2014
Merged

Adds 'Brackets Homepage' entry to help menu #7746

merged 2 commits into from
May 15, 2014

Conversation

bschwb
Copy link
Contributor

@bschwb bschwb commented May 4, 2014

as requested in Issue #7579.

@Denisov21
Copy link
Contributor

@BerndSchwarzenbacher and @SAplayer Thank you for help!

@marcelgerber
Copy link
Contributor

Well, I haven't contributed anything here. That's just git.
@BerndSchwarzenbacher Could you try git rebase upstream/master && git push -f to fix the git issue?

@bschwb
Copy link
Contributor Author

bschwb commented May 5, 2014

Ups I messed that up. Seems like it is clean know. Thank you @SAplayer for helping out.

@redmunds
Copy link
Contributor

redmunds commented May 6, 2014

@larz0 Please review.

@larz0
Copy link
Member

larz0 commented May 6, 2014

@BerndSchwarzenbacher @redmunds looks good but is it okay to just use "brackets.io" instead of "brackets.io/index.html"?

@redmunds
Copy link
Contributor

redmunds commented May 6, 2014

@larz0 Yes, "brackets.io" is okay and more flexible.

@BerndSchwarzenbacher "/index.html" should be removed.

@bschwb
Copy link
Contributor Author

bschwb commented May 7, 2014

@redmunds @larz0 I'm not sure if you get notified if I just commit the change, so just wanted you to know that I changed it yesterday. Thanks for pointing out.

@peterflynn
Copy link
Member

Reassigning @redmunds since it looks like @larz0 has given the ok (please assign back if not)

@peterflynn peterflynn assigned redmunds and unassigned larz0 May 15, 2014
@redmunds
Copy link
Contributor

@BerndSchwarzenbacher To answer your question, no we're not notified when you just commit a change to you branch, so it's best to add a comment to notify us.

Looks good. Thanks. Merging.

redmunds added a commit that referenced this pull request May 15, 2014
Adds 'Brackets Homepage' entry to help menu
@redmunds redmunds merged commit 368a63c into adobe:master May 15, 2014
@@ -362,6 +362,7 @@ define({
"CMD_RELEASE_NOTES" : "Release Notes",
"CMD_GET_INVOLVED" : "Get Involved",
"CMD_SHOW_EXTENSIONS_FOLDER" : "Show Extensions Folder",
"CMD_HOMEPAGE" : "Brackets Homepage",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this have read "{APP_TITLE} Homepage" instead, like two lines down for the About window?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I re-opened #7579 .

cc @BerndSchwarzenbacher

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants