-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Adds 'Brackets Homepage' entry to help menu #7746
Conversation
@BerndSchwarzenbacher and @SAplayer Thank you for help! |
Well, I haven't contributed anything here. That's just git. |
as requested by issue #7579.
Ups I messed that up. Seems like it is clean know. Thank you @SAplayer for helping out. |
@larz0 Please review. |
@BerndSchwarzenbacher @redmunds looks good but is it okay to just use "brackets.io" instead of "brackets.io/index.html"? |
@larz0 Yes, "brackets.io" is okay and more flexible. @BerndSchwarzenbacher "/index.html" should be removed. |
@BerndSchwarzenbacher To answer your question, no we're not notified when you just commit a change to you branch, so it's best to add a comment to notify us. Looks good. Thanks. Merging. |
Adds 'Brackets Homepage' entry to help menu
@@ -362,6 +362,7 @@ define({ | |||
"CMD_RELEASE_NOTES" : "Release Notes", | |||
"CMD_GET_INVOLVED" : "Get Involved", | |||
"CMD_SHOW_EXTENSIONS_FOLDER" : "Show Extensions Folder", | |||
"CMD_HOMEPAGE" : "Brackets Homepage", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this have read "{APP_TITLE} Homepage"
instead, like two lines down for the About window?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! I re-opened #7579 .
cc @BerndSchwarzenbacher
as requested in Issue #7579.