-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Conversation
@RaymondLim Could you take a look at this PR and see if you can figure out why this language isn't working? Thanks. cc @diomed |
@redmunds You need to add |
@@ -61,6 +61,7 @@ The following languages have been contributed by the Brackets community: | |||
* Persian-Farsi (fa-ir) | |||
* Finnish (fi) | |||
* Hungarian (hu) | |||
* Croatian (hr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line should be above Hungarian (hu)
.
Yes, that was it. There are so many "strings.js" files that I looked at the wrong one for that step. Thanks. @diomed This now works. This comment mentions a few more strings to review. |
@diomed I notice a few more strings in the strings.js file need to be translated:
Also, the last 2 words of this long one:
|
@redmunds You also need to add |
Done. Thanks. cc @diomed |
I've updated strings.js with some of requested strings, and updated some of existing strings with new name, because I did not properly translate previous one. However, I'm unsure of this:
Timing Function - what is that, what does it do - can someone explain it to me, so I could translate it properly?. |
Paste this css rule in a style sheet:
Put cursor in each line and press Ctrl/Cmd-E to invoke the timing function editors for each of those functions. |
I've checked my CSS book and translated as it says. |
Looks good. Merging. |
Updates to add Croatian language
Hi! I'm not sure do you still receive my updated or not, so I'm just writing here to let you know that I've changed a few strings; 1 was untranslated, and other ones were not grammatically correct, so I've fixed them too. |
@diomed I think that I merged all of your strings into the brackets master branch on April 21st in this commit -- take a look and see what's there. I have not merged any of your changes since then. You need to submit a pull request each time you have additional changes. Note that I researched using transifex.com for Brackets, but they currently do not support the requirejs i18n system that we use. Let them know to add support for it! |
Updates to add Croatian language from diomed.
This started with #7504 and #7515, so I merged those PRs here. There are also a few more changes from https://github.com/diomed/brackets.