This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Automatically scroll find selection into view #5861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| @@ -144,6 +144,7 @@ define(function (require, exports, module) { | |||
| centerOptions = Editor.BOUNDARY_IGNORE_TOP; | |||
| } | |||
| editor.setSelection(cursor.from(), cursor.to(), true, centerOptions); | |||
| cm.scrollIntoView({from: cursor.from(), to: cursor.to()}); | |||
There was a problem hiding this comment.
Yes, this always shows selection horizontally, but it cancels the "center vertically" functionality. I see the same results with:
editor.setSelection(cursor.from(), cursor.to(), false);
//cm.scrollIntoView({from: cursor.from(), to: cursor.to()});
I think the problem may be that the Editor.centerOnCursor() function passes null as x position to this.setScroll(). Maybe that used to work and there was a change in CodeMirror. Try looking into cm.scrollIntoView() to see what it's doing.
|
Done with initial review. |
|
@redmunds, good catch, I didn't even notice that behavior. Fix submitted. |
|
Looks good. Merging. |
redmunds
added a commit
that referenced
this pull request
Nov 6, 2013
Automatically scroll find selection into view
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #3063 by forcing the editor to always scroll a find selection into view.