-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Conversation
Do you know anybody here on github who could review this? |
Unfortunately, I don't know anybody with authority who could review my Romanian translation, I am a native speaker of Romanian, and want to use Brackets in my native language. |
Hey @micnic, we don't need anyone with authority, just some other native speaker that could go through your translation, review it and let us know. If you don't know about anyone, probably @couzteau will ask in the dev list to see if someone pops up. Additionally, we'll need you to sign the CLA before we can accept your contributions. You can do that at http://dev.brackets.io/brackets-contributor-license-agreement.html |
Signed, I will try to find some more native speakers today, hope will find a lot of them. |
Hello, I reviewed the strings and they look good. |
Hi, great work, translations are fine. |
Checked. I have some minor remarks (I added few comments to commit) but overall it looks really good. |
@bumbu Ceea ce tine de remarci, m-am condus in general de localizarea franceza, ma mai uit si mai modific daca trebuie, iar de niciunul vs nici un vezi aici: http://dexonline.ro/articol/Niciun_sau_nici_un%3F |
Added some improvements after @bumbu 's remarks. |
Eu as pune o virgulă după Live Preview: "LIVE_DEVELOPMENT_ERROR_MESSAGE" : "Pentru a lansa Live Preview, Google Chrome trebuie să fie relansat cu opțiunea de depanarea la distanță activată. În rest pare ok la o verificare vizuală. I'm native speaker and I verified translations. Everything is ok. |
@unNene , prima construcție trebuie să aibă un sens independent (să aibă un predicat) de ceea ce urmează după virgulă, dar aici e ceva de tipul: Pentru a cumpăra lapte trebuie să avem bani :D mai multe informații aici: http://www.scientia.ro/homo-humanus/44-dificultati-ale-limbii-romane/152-reguli-folosire-virgula.html |
Yes, it is a good translation. |
Hi @jbalsas, glad to hear this, I reviewed the files again and didn't find any typo or something wrong, we are good to go! |
@bumbu Awesome!! @micnic Thanks a lot for working on this! If you have time, a couple of extra strings landed in the last days 74dafa4 and the Serbian and Persian locale names. Feel free to submit a different PR for those. @bumbu @unNene @romanroibu @cojocaru @sandulungu Thanks so much everyone for taking your time to review this!! Merging |
Romanian locale