[fi] Replace quotes with correct ones #5812
Conversation
|
@valtlait Could you review this? |
|
I´ve accepted this now. |
ghost
assigned 
| @@ -125,7 +125,7 @@ define({ | |||
| "NO_UPDATE_TITLE" : "Olet ajantasalla!", | |||
| "NO_UPDATE_MESSAGE" : "Käytät uusinta versiota sovelluksesta {APP_NAME}.", | |||
|
|
|||
| "FIND_IN_FILES_TITLE" : "kohteelle \"{4}\" {5} - {0} {1} {2} {3}", | |||
| "FIND_IN_FILES_TITLE" : "kohteelle ”{4}” {5} - {0} {1} {2} {3}", | |||
There was a problem hiding this comment.
This would make the finnish localization incosnistent with other languages. Doesn't seem good to merge to me. What's the benefit of the new quotes?
There was a problem hiding this comment.
As I said earlier, " is not a quotation mark in Finnish language. The new quote is the most widely used in Finnish so I prefer to use it. Wikipedia, the source of all facts, says that different languages, in this case English and Finnish, have different quotation marks.
I understand that we are handling with quotations. If not, please tell me what they are so I can check Finnish equivalent.
|
Thank @jukkah . that makes sense. Merging. Thanks @valtlait for reviewing. |
|
@jukkah before I can merge this please merge master into this branch |
…-fix Conflicts: src/nls/fi/strings.js Fix also new CSS_QUICK_EDIT_NO_MATCHES key added in adobe#5798.
|
Good to merge now. Thanks @jukkah |
[fi] Replace quotes with correct ones
In Finnish language
\u0022(") is not a valid quotation mark even if it has been used so widely.\u201D(”) is a valid one. [1][1] Section ”Lainausmerkkien nimiä ja muotoja” http://www.cs.tut.fi/~jkorpela/kielenopas/4.7.html#lain-nimet