Persian translation for Brackets #5164
Conversation
Translated to Persian language
Some improvement in translation
Some improvement in translation
ghost
assigned 
|
@pgrammer Thanks for the contribution. Please sign the contributor license agreement http://dev.brackets.io/brackets-contributor-license-agreement.html so that we can merge this pull request after it's been reviewed. Do you happen to know Persian speakers that can review your translation? If not, I'll post to the google group http://groups.google.com/group/brackets-dev looking for help. |
| @@ -0,0 +1,452 @@ | |||
|
|
|||
| //********************* Translated by: Mohammad.Yaghobi | |||
There was a problem hiding this comment.
Please use our standard file header.
There was a problem hiding this comment.
Ok, Can I set my email(or...) after Brackets's standard header?
There was a problem hiding this comment.
No, but your github account will be tied to the commit so you're authorship will be recorded that way.
|
Code review complete. Still needs a translation review and needs to merge master to fix conflicts. |
|
I signed the contributor license agreement. |
|
I've posted to the google group to see if anyone can help with the translation review https://groups.google.com/d/topic/brackets-dev/AH8grjS1PDw/discussion. |
|
why not merge my pullrequest? |
|
Sorry, @jasonsanjose has been on vacation. We normally want at least one other native language speaker to review localization pull requests--it looks like he posted to the brackets-dev Google Group asking for a reviewer but didn't get any response. If you know another native speaker who can review your translation, please have them take a look and comment. I just bumped the thread on the Google Group as well. |
|
@couzteau would you mind tracking this while @jasonsanjose is out? Thanks. |
|
@njx sure. will do |
|
Thank you @couzteau. |
|
The file strings.js at src/nls/root also needs to be updated, so that Persian shows up in the language selection dialog: "LOCALE_FA_IR" : "Persian", before Polish |
|
I also spot checked some translations and found no problems. |
|
I reviewed the translation via google translate. It all seemed to make sense, no blockers. I'll go ahead withe the merge |
I've translated brackets to Persian language.