This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Make File > Save work on the currently focused editor #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // See if any inlines have focus | ||
| _currentEditor.getInlineWidgets().forEach(function (widget) { | ||
| if (widget.data.editor.hasFocus()) { |
There was a problem hiding this comment.
Although it never happens today, the inline-provider API is structured such that an inline widget could be something other than an inline editor -- meaning 'data' might not necessarily have an 'editor' property. (Eventually when we have real extensibility we may want to make this more rigid, e.g. forcing the data bag to be tagged with a type enum or be an object that we can check with instanceof... but so far we've just been checking for 'editor' to decide whether an inline widget is an inline editor or not).
There was a problem hiding this comment.
Additional test for widget.data.editor added.
|
Done reviewing |
|
Looks great! Merging... |
peterflynn
added a commit
that referenced
this pull request
Mar 13, 2012
Make File > Save work on the currently focused editor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@peterflynn
This change has a few small parts:
The only part I'm not sure about is #2. We now have an anonymous object floating around that ties together a document and an editor. This is probably fine for now, but will need to be changed once we have proper Document <--> Editor mapping in place.