Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Fix for Issue #3720 : File Rename should complete when clicking anywhere in project panel #4323

Closed
wants to merge 1 commit into from
Closed

Fix for Issue #3720 : File Rename should complete when clicking anywhere in project panel #4323

wants to merge 1 commit into from

Conversation

vladnicula
Copy link

Discussion here #3720 (comment).

* clicking anywhere in mainView.
* @type {jQueryObject}
*/
var $mainView;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a reference to the div.main-view element in this variable. Maybe we'll need to use the main-view div again in this file.

@ghost ghost assigned JeffryBooher Jun 24, 2013
@JeffryBooher
Copy link
Contributor

The code looks fine. If you start a rename and then hide the sidebar, however, you are still in rename mode.
You can fix that with a couple of listeners:

CommandManager.register(Strings.CMD_BEFORE_MENUPOPUP, Commands.APP_BEFORE_MENUPOPUP, forceFinishRename);
$("#sidebar").on("panelCollapsed", forceFinishRename);

The first one should finish the rename when any popup menu is about to show and the second if the panel is hidden for any reason.

@vladnicula
Copy link
Author

Ok, will add the extra code tomorrow and update this.

@JeffryBooher
Copy link
Contributor

@vladnicula Is the additional work done on this?

@vladnicula
Copy link
Author

No, I won't get to it this weeks, I'm busy with work, sorry.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants