This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Adds pixel units to localisation #3811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -344,7 +344,7 @@ define(function (require, exports, module) { | |||
| $previewContainer.find(".image-preview > img").on("load", function () { | |||
| $previewContent | |||
| .append("<div class='img-size'>" + | |||
| this.naturalWidth + " x " + this.naturalHeight + " pixels" + | |||
| this.naturalWidth + " x " + this.naturalHeight + " " + Strings.UNIT_PIXELS + " " + | |||
There was a problem hiding this comment.
Extra space + " " after UNIT_PIXELS isn't needed.
|
@kjgorman Initial review complete. 1 minor comment. |
|
Yes, of course, sorry for so many trivial errors... still too early in New Zealand |
|
Again, no problem. Thanks for the contribution. Merging. |
jasonsanjose
added a commit
that referenced
this pull request
May 13, 2013
Adds pixel units to localisation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt #2. Fix for #3713