This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Clone HTML for dialogs #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng it directly, so we can have multiple instances.
| @@ -177,11 +193,12 @@ define(function (require, exports, module) { | |||
| * If the dialog is visible, immediately closes it. The dialog callback will be called with the | |||
There was a problem hiding this comment.
Should amend the docs to say something like, "If any dialog of the given type if open..."
|
Code review done. I played with it and it looks good. With that one comment fixed, I think it's good to merge anytime. |
|
Updated the comment--please take a look and merge when you can. Thanks. |
peterflynn
added a commit
that referenced
this pull request
Feb 15, 2012
Fix issue #187 (brackets.showModalDialog() breaks if similar dialogs are ever stacked / shown simultaneously) -- Clone HTML for dialogs
sedge
pushed a commit
to sedge/nimble
that referenced
this pull request
May 14, 2015
…r err objects.
gideonthomas
pushed a commit
to gideonthomas/brackets
that referenced
this pull request
May 15, 2015
…r err objects.
gideonthomas
pushed a commit
to gideonthomas/brackets
that referenced
this pull request
May 20, 2015
…r err objects.
sedge
pushed a commit
to sedge/nimble
that referenced
this pull request
May 27, 2015
…r err objects.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@peterflynn
For #187, we now no longer directly show the original dialog DOM nodes. Instead, we clone them each time showModalDialog() is invoked. As part of this change, the original dialog templates are now addressed by a class name rather than by ID, and the marker class "template" is assumed to be applied to them.